Completed the task #2169
Completed the task #2169
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 The code meets the task requirements and constraints, correctly handling the conversion of date formats as specified. While there are some assumptions about the position of separators in the fromFormat and toFormat arrays, these do not critically impact the functionality given the task constraints. In future projects, consider dynamically determining separators to enhance flexibility and robustness. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -8,7 +8,32 @@ | |||
| * @returns {string} | |||
| */ | |||
| function formatDate(date, fromFormat, toFormat) { | |||
| // write code here | |||
| const separator = fromFormat[3]; | |||
There was a problem hiding this comment.
The code assumes that the separator is at index 3 of the fromFormat array. This assumption might not hold true if the format is different, such as 'YYYY-MM-DD'. Consider revising the logic to dynamically determine the separator based on the actual date string or format pattern.
| dateObj['YYYY'] = year < 30 ? `20${dateObj['YY']}` : `19${dateObj['YY']}`; | ||
| } | ||
|
|
||
| const newSeparator = toFormat[3]; |
There was a problem hiding this comment.
Similar to the issue with fromFormat, the code assumes the separator is at index 3 of the toFormat array. This might not be correct for all formats. Ensure that the separator is correctly identified or passed separately.
No description provided.